|
325 | OpenPandora Main OS | Core | Bug Report | Low | Impossible to not set password at first boot | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
The Wiki states that the Pandora can be used without setting a user password on first boot. But when the password and password confirmation field are left empty, an error pops up saying that there is a password missmatch.
(Please don't fix this bug by just changing the statement in the Wiki ;-) |
|
272 | OpenPandora Development OS | Backend / Core | Bug Report | Medium | kernel 3.2.1 DSS export omapfb update mode functions | Unconfirmed | |
AllRelease 2 (Yars Revenge) |
Task Description
The update mode functions have moved from the DSS layer to omapfb implementaion.
This patch exports the new function symbols for use by the TI drivers.
--- a/drivers/video/omap2/omapfb/omapfb-ioctl.c
+++ b/drivers/video/omap2/omapfb/omapfb-ioctl.c
@@ -22,6 +22,7 @@
#include
#include
+#include
#include
#include
#include
@@ -359,6 +360,7 @@ int omapfb_set_update_mode(struct fb_info *fbi,
return r;
}
+EXPORT_SYMBOL(omapfb_set_update_mode);
int omapfb_get_update_mode(struct fb_info *fbi,
enum omapfb_update_mode *mode)
@@ -381,6 +383,7 @@ int omapfb_get_update_mode(struct fb_info *fbi,
return 0;
}
+EXPORT_SYMBOL(omapfb_get_update_mode);
/* XXX this color key handling is a hack... */
static struct omapfb_color_key omapfb_color_keys[2]; |
|
222 | OpenPandora Main OS | Application | Bug Report | Low | Login Screen does not accept all symbols of the form Fn... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Problem - Login Screen does not accept all symbols of the form Fn+char
Reproducibility - always
Actual results - the characters :?#|$€"‘£¥@!_ do not work on the Login Screen with the Pandora's keyboard. When fn then the corresponding character is pressed, nothing is added to the string.
Expected results - these characters should appear just like any other character
Work Around - an external keyboard was able to enter these characters
Aditional Information - While the characters :?#|$€"‘£¥@!_ do not work, the characters ;/\'-+=`() work just fine. |
|
260 | OpenPandora Main OS | Core | Bug Report | Medium | Low Power Mode: Input (keyboard, nub) still taken. Appl... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
This is the related documentation:
http://pandorawiki.org/Power_modes#Low_Power
(Please update accordingly as part of the issue resolution)
FROM MY USER EXPERIENCE:
If you put the Pandora into Low Power Mode, then press some keys, and then wake the Pandora back into Normal Mode, your input (both keys and nubs, haven't tried with USB input yet) seem to have triggered something while the device was in Low Power Mode!
What does really happen in Low Power Mode concerning execution and input?
a) Input is received AND triggers as application execution continues
or
b) Kernel/driver queues the input signals into a buffer, and executes them on wake?
If supposition a) or b) is true, then this would be one more reason to properly implement: FS#259
OBSERVANCE EXAMPLE 1:
1) Start MiniMenu. Mentally note down your active tab.
2) Put Pandora to Low Power Mode.
3) Press shoulder button R once.
4) Wake Pandora to Normal Mode. You are now one tab to the right of where you left. Input must have been caught in Low Power Mode, but wether execution of it happened while Low Power Mode or later after wake in Normal power Mode is unclear.
OBSERVANCE EXAMPLE 2:
1) Start gedit (a text editor). Insert the digit "1".
2) Put Pandora to Low Power Mode.
3) Press: CTRL-N 2 CTRL-N 3 CTRL-N 4. (Without the spaces)
4) Wake Pandora to Normal Mode.
5) For a fraction of a second you see the tabs building up. Either the input was really received AND executed while Low Power Mode and what you see is just a delayed window manager refreshment, or the input was queued in Low Power Mode, and only executed on wake. |
|
295 | Additional Applications | Application | Bug Report | Low | Making the pnd file executable | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Hi there,
it would be neat if an rc script containing this could be added to the os (and run on startup) :
if [ ! -e /proc/sys/fs/binfmt_misc/register ];then
modprobe binfmt_misc
mount -t binfmt_misc none /proc/sys/fs/binfmt_misc
fi
echo ":squashPND:M::hsqs::/usr/bin/pnd_run:">/proc/sys/fs/binfmt_misc/register
That render all the SquashFS executable directy by clicking them on the icon. Sadly there is no way to pass the arguments to the apps (as pnd_run dont support that).
A similar line could be added to support iso pnd. |
|
262 | OpenPandora Main OS | Application | Bug Report | Medium | MiniMenu: 1) "Notes line" cannot be deleted. 2) Note li... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Steps to reproduce the bug(s):
1) In MiniMenu select an arbitrary app.
2) Press SPACE to bring up the contextual menu.
3) Select "Edit notes line 1".
4) Insert your string and confirm.
5) Now at a later time you may decide to remove your note line again. Therefore you select the same app again in MiniMenu, then repeat steps 2-3, but this time:
a) Erase all characters so that you get an empty string and then confirm. RESULT: Your change is simply ignored! There should be a possibility within MiniMenu to remove/reset note lines, the simplest being to simply accept an empty string as an input, that's what an average user will try if s/he does not find a dedicated "Delete note line" command.
b) As a workaround I tried something and detected yet another bug! As I could not create an empty string, I simply created a note line only containing 1 SPACE character (=the string " ") and confirmed. This got accepted.
If MiniMenu is in detailed view mode (press the A-button or TAB in order to bring it up, if it is not already there) and you slide over an app whose note line is " ", MiniMenu crashes!
Maybe the bug is connected with the writing to / the parsing from the .OVR (override) files which MiniMenu creates for the affected files, as the separating value in OVR files seems to be TAB, and SPACE is also WHITESPACE, therefore some parsers probably skip/misinterpret this, and MiniMenu then catches an unexpected situation!
WORKAROUND: If you ran into the problem, that you cannot get rid of the note lines anymore, simply start a file browser of your choice, navigate to the location of the affected .PND file and find its sister .OVR (override) file and delete it or edit it accordingly! |
|
265 | OpenPandora Main OS | Application | Bug Report | Medium | MiniMenu: Flawed tab display of sub-categories if they ... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
I assigned personal subcategories to some of my games.
Some of those subcategories share the same beginning string, i.e: Shooter, ShooterBallistic ShooterScoller.
MiniMenu displays those subcategories with flaws! See the ASCII screenshots below.
Note: The star symbols indicate the currently active selection.
The main category tab "Game" being active:
----------------------------------------------------------
| All | Audio | AudioVideo | Education |*Game*| Graphics |
----------------------------------------------------------
ActionGame AdventureGame ArcadeGame BlocksGame ...
Shooter ShooterBallistic ShooterScroller ...
GameA GameB GameC ...
----------------------------------------------------------
Now if I navigate into the sub-category "Shooter", everything normal:
----------------------------------------------------------
|*Shooter*|
----------------------------------------------------------
.. ShooterA ShooterB ShooterC ...
----------------------------------------------------------
But if I navigate to the sub-category "ShooterBallistic", strangely MiniMenu shows 2 tabs, "Shooter" and "ShooterBallistic", and jumps right into "Shooter".
----------------------------------------------------------
|*Shooter*| ShooterBallistic |
----------------------------------------------------------
.. ShooterA ShooterB ShooterC ...
----------------------------------------------------------
In order to reach my intended tab "ShooterBallistic" I need to navigate to it again. Annoying. There the contents are as expected:
----------------------------------------------------------
| Shooter |*ShooterBallistic*|
----------------------------------------------------------
.. ShooterBallisticA ShooterBallisticB ShooterBallisticC
----------------------------------------------------------
The flaw is the same for all other sub-categories beginning with "Shooter...". All have the flaw as shown in the example "ShooterBallistic", only that it is themselves instead of "ShooterBallistic". One more example to be perfectly clear:
----------------------------------------------------------
| Shooter |*ShooterScroller*|
----------------------------------------------------------
.. ShooterScrollerA ShooterScrollerB ShooterScrollerC
---------------------------------------------------------- |
|
258 | OpenPandora Main OS | Application | Bug Report | Low | MiniMenu: Pressing key multiple times only cycles focus... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
EXAMPLE: MiniMenu with the option "Subcategories as folders" YES, and the current active tab i.e. "Game" lists:
Subgenre folders: ActionGame, AdventureGame, ArcadeGame, BlocksGame, …
App items: Abuse, Amoeboax, Arkaniod, Bloqus, …
THE BUG: Pressing "A" multiple times only cycles the focus between folders (ActionGame, AdventureGame, ArcadeGame), but never reaches the app items (Abuse, Amoeboax, Arkaniod).
BESIDES THIS BUG in the current keyboard item selection logic, I kindly inquire to implement: FS#243 |
|
301 | OpenPandora Main OS | Core | Bug Report | Medium | Missing X keybinding for colon symbol | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
As verified with xev, an attached bluetooth keyboard can not generate colon (shift semicolon). xmodmap shows that (unlike a standard Linux system) shift-semicolon is mapped to NoSymbol. While it's find that there's a special symbol to get semicolon on the built-in keyboard, the other binding really should be there in support of attached keyboards. |
|
178 | OpenPandora Main OS | Core | Bug Report | Low | Mount-loop when booting from SD-card | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
When booting the pandora-OS from sd-card by using the official tar, you will end up with your sd-card being mounted twice: once as / and once as /media/. I solved this by adding "/dev/mmcblk0" to "/etc/udev/mount.blacklist". Maybe this should be added to the default tarball? I'm not sure as it might be used in other ways maybe (beside SD-card-installation)?
Background: I ran "updatedb" as root and have been notified by a message that there was a mount-loop. After adding the above modification the system still booted fine and "updatedb" ran nicely without a warning. |
|
218 | Additional Applications | Application | Bug Report | Low | nc (netcat) can't create tcp connections | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Zaxxon Hotfix 5.
Example (dropbear is running):
------------------------
~# nc -vvvv localhost 22
Notice: Real hostname for localhost [127.0.0.1] is localhost.localdomain
Total received bytes: 0
Total sent bytes: 0
~# telnet localhost 22
SSH-2.0-dropbear_0.51
------------------------
All required libraries seem present, strace output is inconclusive. |
|
330 | OpenPandora Main OS | Core | Bug Report | Low | NetworkManager crashes after suspend to RAM | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Suspend to RAM uses less power than the low power mode, but the NetworkManager crashes often after the Pandora woke up from suspend to RAM.
This could be fixed with an update of NetworkManager. |
|
135 | OpenPandora Main OS | Application | Bug Report | Low | OOM Killer causes loss of items in xfce4-panel configur... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
When the Pandora runs out of memory and the Out-Of-Memory killer fires, the Applications/Settings/xfce4/panel/panels.xml loses the entries for the menu button and the power monitor. |
|
223 | OpenPandora Main OS | Core | Bug Report | High | op_power.sh kills gles context | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
opengles and op_power.sh don't like each other very much.
whenever returning from low power to full power mode again, opengles rendering is just dead.
the reason for this issue are following 2 lines within op_power.sh
18 echo 0 > /sys/devices/platform/omapfb/graphics/fb0/blank
...
66 echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank
if these lines are removed/commented, the gles rendering just resumes fine. |
|
315 | OpenPandora Main OS | Core | Bug Report | Medium | Pairing bluetooth SPP devices doesn't work with XFCE | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Hi, sadly the XFCE bluetooth manager seems to have problems with pairing simple SPP devices (an BT GPS mouse here).
1. Enable BT
2. BT Manager -> Add new device
3. Confirm Dialog and wait for scanning
4. Pick device
5. Select PIN options -> "0000" (here for me)
In next step the dialog still asks you to enter a random PIN at your BT device (which is impossible here).
Thus it seems, that the XFCE dialog makes troubles, I tried it with 2 different GPS. Pairing the GPS manually works fine:
sudo rfcomm connect rfcomm0 00:18:E4:26:5F:14 |
|
297 | OpenPandora Main OS | Core | Bug Report | Low | pandora button and taskbar autohide | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
When the taskbar is set to autohide, the Pandora button does not bring up the menu anymore. |
|
274 | OpenPandora Development OS | Backend / Core | Bug Report | Medium | Patch for TI SGX 4.04.00.03 drivers to compile against ... | Unconfirmed | |
AllRelease 2 (Yars Revenge) |
Task Description
This patch when applied aginst TI 4.04.00.03 SGX drivers will allow building the pvr kernel modules.
This relies on task 272 (kernel patch) and should be used inconjuction with task 273
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_displayclass.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_displayclass.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_displayclass.c 2011-06-20 21:03:33.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_displayclass.c 2012-02-09 08:37:21.000000000 +1100
@@ -830,7 +830,11 @@
unsigned long ulLCM;
unsigned uiFBDevID = psDevInfo->uiFBDevID;
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_lock();
+#else
acquire_console_sem();
+#endif
psLINFBInfo = registered_fb[uiFBDevID];
if (psLINFBInfo == NULL)
@@ -972,7 +976,11 @@
ErrorModPut:
module_put(psLINFBOwner);
ErrorRelSem:
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_unlock();
+#else
release_console_sem();
+#endif
return eError;
}
@@ -982,7 +990,11 @@
struct fb_info *psLINFBInfo = psDevInfo->psLINFBInfo;
struct module *psLINFBOwner;
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_lock();
+#else
acquire_console_sem();
+#endif
psLINFBOwner = psLINFBInfo->fbops->owner;
@@ -993,7 +1005,11 @@
module_put(psLINFBOwner);
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_unlock();
+#else
release_console_sem();
+#endif
}
static OMAPLFB_DEVINFO *OMAPLFBInitDev(unsigned uiFBDevID)
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c 2011-06-20 21:03:33.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c 2012-02-09 13:14:28.000000000 +1100
@@ -24,11 +24,14 @@
*
******************************************************************************/
+
+#include
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
@@ -236,8 +239,11 @@
struct fb_var_screeninfo sFBVar;
int res;
unsigned long ulYResVirtual;
-
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_lock();
+#else
acquire_console_sem();
+#endif
sFBVar = psDevInfo->psLINFBInfo->var;
@@ -268,31 +274,37 @@
printk(KERN_INFO DRIVER_PREFIX ": %s: Device %u: fb_pan_display failed (Y Offset: %lu, Error: %d)\n", __FUNCTION__, psDevInfo->uiFBDevID, psBuffer->ulYOffset, res);
}
}
-
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_unlock();
+#else
release_console_sem();
+#endif
}
OMAPLFB_UPDATE_MODE OMAPLFBGetUpdateMode(OMAPLFB_DEVINFO *psDevInfo)
{
struct omap_dss_device *psDSSDev = fb2display(psDevInfo->psLINFBInfo);
OMAP_DSS_DRIVER(psDSSDrv, psDSSDev);
-
- enum omap_dss_update_mode eMode;
-
- if (psDSSDrv == NULL || psDSSDrv->get_update_mode == NULL)
- {
- DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: Can't get update mode\n", __FUNCTION__, psDevInfo->uiFBDevID));
- return OMAPLFB_UPDATE_MODE_UNDEFINED;
+ if (psDSSDrv == NULL || psDSSDev == NULL)
+ {
+ DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: No DSS device\n", __FUNCTION__, psDevInfo->uiFBDevID));
+ }
+ enum omapfb_update_mode eMode;
+
+ if (!omapfb_get_update_mode(psDevInfo->psLINFBInfo, &eMode))
+ {
+// DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: Can't get update mode\n", __FUNCTION__, psDevInfo->uiFBDevID));
+ return OMAPLFB_UPDATE_MODE_AUTO;
+// return OMAPLFB_UPDATE_MODE_UNDEFINED;
}
- eMode = psDSSDrv->get_update_mode(psDSSDev);
switch(eMode)
{
- case OMAP_DSS_UPDATE_AUTO:
+ case OMAPFB_AUTO_UPDATE:
return OMAPLFB_UPDATE_MODE_AUTO;
- case OMAP_DSS_UPDATE_MANUAL:
+ case OMAPFB_MANUAL_UPDATE:
return OMAPLFB_UPDATE_MODE_MANUAL;
- case OMAP_DSS_UPDATE_DISABLED:
+ case OMAPFB_UPDATE_DISABLED:
return OMAPLFB_UPDATE_MODE_DISABLED;
default:
DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: Unknown update mode (%d)\n", __FUNCTION__, psDevInfo->uiFBDevID, eMode));
@@ -307,10 +319,10 @@
{
struct omap_dss_device *psDSSDev = fb2display(psDevInfo->psLINFBInfo);
OMAP_DSS_DRIVER(psDSSDrv, psDSSDev);
- enum omap_dss_update_mode eDSSMode;
+ enum omapfb_update_mode eDSSMode;
int res;
- if (psDSSDrv == NULL || psDSSDrv->set_update_mode == NULL)
+ if (psDSSDrv == NULL)
{
DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: Can't set update mode\n", __FUNCTION__, psDevInfo->uiFBDevID));
return OMAPLFB_FALSE;
@@ -319,20 +331,20 @@
switch(eMode)
{
case OMAPLFB_UPDATE_MODE_AUTO:
- eDSSMode = OMAP_DSS_UPDATE_AUTO;
+ eDSSMode = OMAPFB_AUTO_UPDATE;
break;
case OMAPLFB_UPDATE_MODE_MANUAL:
- eDSSMode = OMAP_DSS_UPDATE_MANUAL;
+ eDSSMode = OMAPFB_MANUAL_UPDATE;
break;
case OMAPLFB_UPDATE_MODE_DISABLED:
- eDSSMode = OMAP_DSS_UPDATE_DISABLED;
+ eDSSMode = OMAPFB_UPDATE_DISABLED;
break;
default:
DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: Unknown update mode (%d)\n", __FUNCTION__, psDevInfo->uiFBDevID, eMode));
return OMAPLFB_FALSE;
}
- res = psDSSDrv->set_update_mode(psDSSDev, eDSSMode);
+ res = omapfb_set_update_mode(psDevInfo->psLINFBInfo, eDSSMode);
if (res != 0)
{
DEBUG_PRINTK((KERN_INFO DRIVER_PREFIX ": %s: Device %u: set_update_mode failed (%d)\n", __FUNCTION__, psDevInfo->uiFBDevID, res));
@@ -441,10 +453,17 @@
OMAPLFB_ERROR OMAPLFBUnblankDisplay(OMAPLFB_DEVINFO *psDevInfo)
{
int res;
-
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_lock();
+#else
acquire_console_sem();
+#endif
res = fb_blank(psDevInfo->psLINFBInfo, 0);
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_unlock();
+#else
release_console_sem();
+#endif
if (res != 0 && res != -EINVAL)
{
printk(KERN_WARNING DRIVER_PREFIX
@@ -459,9 +478,17 @@
static void OMAPLFBBlankDisplay(OMAPLFB_DEVINFO *psDevInfo)
{
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_lock();
+#else
acquire_console_sem();
+#endif
fb_blank(psDevInfo->psLINFBInfo, 1);
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_unlock();
+#else
release_console_sem();
+#endif
}
static void OMAPLFBEarlySuspendHandler(struct early_suspend *h)
@@ -692,9 +719,17 @@
flush_workqueue(psDevInfo->psSwapChain->psWorkQueue);
}
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_lock();
+#else
acquire_console_sem();
+#endif
ret = fb_blank(psDevInfo->psLINFBInfo, iFBMode);
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,38)
+ console_unlock();
+#else
release_console_sem();
+#endif
OMAPLFBCreateSwapChainUnLock(psDevInfo);
@@ -717,7 +752,6 @@
static int __init OMAPLFB_Init(void)
#endif
{
-
if(OMAPLFBInit() != OMAPLFB_OK)
{
printk(KERN_WARNING DRIVER_PREFIX ": %s: OMAPLFBInit failed\n", __FUNCTION__);
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/common/resman.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/common/resman.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/common/resman.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/common/resman.c 2012-02-09 23:33:43.000000000 +1100
@@ -24,15 +24,17 @@
*
******************************************************************************/
+#include
#include "services_headers.h"
#include "resman.h"
#ifdef __linux__
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,9)
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/event.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/event.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/event.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/event.c 2012-02-09 09:00:12.000000000 +1100
@@ -24,11 +24,14 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
#include
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,22))
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mmap.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mmap.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mmap.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mmap.c 2012-02-09 08:56:41.000000000 +1100
@@ -24,11 +24,14 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
#include
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.c 2012-02-09 08:52:48.000000000 +1100
@@ -24,11 +24,14 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
#include
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.h b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.h
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.h 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mm.h 2012-02-09 08:55:49.000000000 +1100
@@ -27,11 +27,14 @@
#ifndef __IMG_LINUX_MM_H__
#define __IMG_LINUX_MM_H__
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
#include
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/module.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/module.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/module.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/module.c 2012-02-09 08:59:05.000000000 +1100
@@ -24,9 +24,13 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
#if !defined(SUPPORT_DRI_DRM)
@@ -44,7 +48,6 @@
#include
#include
#include
-#include
#include
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.c 2012-02-10 00:24:09.000000000 +1100
@@ -24,10 +24,13 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
-#include
+#endif
#include
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.h b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.h
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.h 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/mutils.h 2012-02-09 08:54:31.000000000 +1100
@@ -27,11 +27,13 @@
#ifndef __IMG_LINUX_MUTILS_H__
#define __IMG_LINUX_MUTILS_H__
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
-
-#include
+#endif
#if !(defined(__i386__) && (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,26)))
#if defined(SUPPORT_LINUX_X86_PAT)
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/osfunc.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/osfunc.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/osfunc.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/osfunc.c 2012-02-09 09:01:16.000000000 +1100
@@ -24,11 +24,14 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
-#include
#include
#include
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,22))
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/proc.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/proc.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/proc.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/proc.c 2012-02-09 08:57:49.000000000 +1100
@@ -24,13 +24,16 @@
*
******************************************************************************/
+#include
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
#include
#include
-#include
#include
#include
#include
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_debug.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_debug.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_debug.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_debug.c 2012-02-09 23:54:38.000000000 +1100
@@ -24,9 +24,12 @@
*
******************************************************************************/
+#include
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
#include
#include
@@ -72,7 +75,7 @@
static PVRSRV_LINUX_MUTEX gsDebugMutexNonIRQ;
-static spinlock_t gsDebugLockIRQ = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(gsDebugLockIRQ);
#if !defined (USE_SPIN_LOCK)
#define USE_SPIN_LOCK (in_interrupt() || !preemptible())
diff -ru a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_drm.c b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_drm.c
--- a/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_drm.c 2011-06-20 21:03:34.000000000 +1000
+++ b/Graphics_SDK_4_04_00_03/GFX_Linux_KM/services4/srvkm/env/linux/pvr_drm.c 2012-02-16 01:58:14.000000000 +1100
@@ -26,14 +26,16 @@
#if defined(SUPPORT_DRI_DRM)
+#include
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,38)
#ifndef AUTOCONF_INCLUDED
#include
#endif
+#endif
#include
#include
#include
-#include
#include
#include
#include
@@ -371,11 +373,23 @@
.poll = drm_poll,
.fasync = drm_fasync,
},
+#if (LINUX_VERSION_CODE name = PVR_DRM_NAME,
+// .pci->id_table = asPciIdList,
+// },
+#endif
.name = PVR_DRM_NAME,
.desc = PVR_DRM_DESC,
@@ -385,6 +399,13 @@
.patchlevel = PVRVERSION_BUILD,
};
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,39))
+static struct pci_driver pci_pvr_driver = {
+ .name = PVR_DRM_NAME,
+ .id_table = asPciIdList,
+};
+#endif
+
static int __init PVRSRVDrmInit(void)
{
int iRes;
@@ -401,7 +422,11 @@
}
#endif
+#if (LINUX_VERSION_CODE |
|
270 | OpenPandora Main OS | Core | Bug Report | Very Low | Power-slider & lid-close events: XFCE observes user set... | New | |
Release 1 (Zaxxon) |
Task Description
STATUS QUO:
If you are in XFCE and hold the power slider for 3 seconds, you thereby trigger the shutdown command.
For 3 more seconds a dialogue box gives you the chance to abort the shutdown ("Shutting down in 3…2…").
Now in MiniMenu no direct shutdown key is available. You first have to quit the running app (via PANDORA key), then call up the menu (via SELECT key), and then navigate to "Shutdown" and confirm it (by B or ENTER).
INQUIRED BEHAVIOR:
1) Thanks to the very recent MiniMenu speedups, these 4 consecutive user interaction steps can now at least be be executed a lot faster.
Nevertheless, offering a 1-button-interaction (via power slider) too, would be nice. Could you please make that available to MiniMenu?
And in general: Make this power-slide-event available to any possible GUI, so that not each GUI has to implement this by itself, but rather the OS catches this event and handles it uniformly, except if a certain GUI WANTS to establish an exception to the rule.
2) Also the "Lid-Close-Settings" seem to be ignored by MiniMenu. MiniMenu seems to have the action "Turn off screen" hardcoded to that event. Please make MiniMenu observe the user settings from "Lid-Close-Settings".
RELATED SOURCE CODE FILES (to my knowledge):
op_lid.sh
op_power.sh
op_bright_up.sh
op_bright_down.sh |
|
121 | OpenPandora Main OS | Base OS | Bug Report | Medium | PyGame Hardware support | New | |
All |
Task Description
PyGame is damn slow (games with scrolling are not at all playable).
Would be nice if Hardware surface could be used :) |
|
158 | OpenPandora Main OS | Base OS | Bug Report | Medium | Refresh rate and BPP | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
On OS Zaxon (hotfix 3).
With "xfconf-query", the resolution is 800x480@60 Hz.
But with the tool in the menu "Settings" -> "Display", the resolution is 800x480@0 Hz.
With Java (opensdk-6-jre 6b18-1.8),
GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getDisplayModes()
return 1 display mode that is 800x480@0 Hz with a BPP of -1.
It seems to be the reason that GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getDisplayMode() return null
and when closing a java application that goes in fullscreen mode to throw an exception (invalid display mode). |
|
190 | OpenPandora Main OS | Core | Bug Report | Medium | Removing desktop-shortkeys does not work | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Try clearing shortcuts in Start->Settings->Window Manager->Keyboard. That doesn't work (for me).
This is a problem because these shortcuts are blocking key-combination in apps, like for example the keymapper in dosbox (CTRL+F1) or refreshing content (CTRL+F5). I tried manual editing or even deleting the configuration file, but changes are not recognized and the file recreated on reboot. |
|
291 | OpenPandora Main OS | Core | Bug Report | Medium | root-owned pndrun_...out file makes PND refuse starting | Assigned | |
Release 1 (Zaxxon) |
Task Description
If a PND has been run as root before (using pnd_run.sh from a root shell) and afterwards it is invoked the normal way, the PND doesn't start, because the .out file cannt be overwritten:
/usr/pandora/scripts/pnd_run.sh: line 26: /tmp/pndrun_firefox.out: Permission denied
Desired solution:
.out file is silently overwitten.
Maybe, if that's not possible, create another .out file with a different name (added counter, for example).
Seen in SuperZaxxon relese 1.5, not in Beta3 as this task is flagged, but there is no choice besides Beta3. |
|
299 | OpenPandora Main OS | Core | Bug Report | Low | run_pnd.sh does not follow PXML.xml or "-d"-Parameter | Assigned | |
Release 1 (Zaxxon) |
Task Description
I call pnd_run.sh with a pnd. The application directory will invariably be /media/SD/pandora/appdata/, no matter if the PXML.xml specifies a different appdata path. Also, the parameter -d for run_pnd.sh is not followed, either.
I tried with vlc.pnd from the app store and with Dosbox74.pnd.
UPDATE: Original submission contained a wrong filename reference. Corrected that typo to the filename intended by the submitter. Admin: porg. |
|
329 | OpenPandora Main OS | Core | Bug Report | Low | Screen turns on when LCD closed | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Issue: The screen accidentally turns on even when the lid is closed.
How to reproduce: "Screen blanking" must be enabled! Close the lid, wait more than 10 minutes, tap either shoulder button. This behaviour happens whether on charge or battery, at the desktop or running an application, provided that the "screen blanking" option is enabled.
Desired outcome: When the Pandora comes out of "screen blanking", it should restore the brightness to the same value that it was before blanking. |
|
324 | OpenPandora Main OS | Core | Bug Report | Low | Sticky keys setting for shift key disabling itself afte... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
The sticky keys option is disabling itself for the shift key. It continues to work with the left shoulder button though.
Unfortunately I have no idea what triggers the sticky option to be disabled. Sometimes it happens after 1-2 minutes, sometimes it takes longer.
I would also like to point out that using the shoulder button instead of the shift button it _not_ an option! This issue has been reported in the forums, but apperantly was never fixed. |
|
318 | Additional Applications | Application | Bug Report | Very Low | strace can not handle conditional SWI's | Unconfirmed | |
All |
Task Description
I found a bug when I tried to debug my code with strace.
It happens when strace has to handle conditional SWI's.
Example: (ASM code) save as "condswi.s"
-----
.data
.text
_globl _start
_start:
mov r0,#0 @ return code
mov r7,#1 @ sys_exit
swine 0
swieq 0
.end
-----
The code assembles/links fine using 'as' and 'ld'.
> as condswi.s
> ld a.out -o condswi
When I want to strace the executable file I got the following error.
> strace ./condswi
'syscall: unknown syscall trap 0x1f000000'
As a result strace quits.
Thanks,
Dennis |
|
300 | OpenPandora Main OS | Core | Bug Report | Low | SuperZaxxon interprets on-disk FAT32 filenames differen... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
With SuperZaxxon Final, I've noticed that stuff running on the Pandora like Thunar and bash are seeing a different interpretation of filenames on disk than when I remove the SD card and insert it into my desktop PC.
Specifically, the following two mismatches appear to be present when using a FAT32-formatted SD card:
First, the Pandora's VFAT support seems to be be operating with different case-handling settings than desktop Linux distros.
Filenames set in all uppercase are forced to all-lowercase on the Pandora (whether they're set on the desktop or the Pandora) but inserting the card into a PC reveals that the. All-lowercase filenames set by software on the Pandora risk appearing in all uppercase when the card is inserted into a PC. (I think the grsync PND is what created the files in question)
Among other things, this forces me to use EITHER the PND-based copy of grsync over the network OR a desktop-based copy of rsync with an SD card reader but not both because the kernel will preserve case differences like ALBION.BAT vs. albion.bat but rsync think they are separate files. (resulting in Flash-killing, time-wasting deletion and re-creation)
It also makes for irritating entries like "zzt" in DOSBox or "ddr" in PyDance where I can't capitalize the filename properly without employing Department of Redundancy Department with "DDR Songs" or "ZZT.The.Game" as an excuse for mixed case.
Second, SuperZaxxon Final seems to be using a different (though still Unicode-capable) filename encoding than all the desktop distros I've tried.
Filenames are preserved properly and all-ASCII filenames are displayed properly in all cases, but any non-ASCII characters appear as gibberish on whichever system was not used to set them.
I've confirmed this problem with these two filenames:
- 03 - The Foggy Dew with Sinéad O'Connor.flac
- Lucky Star - Native Misao (Touhou - Native Faith) ???????????????????×??????.mp4
As a Canadian user, my desktops use the "en_CA.utf8" locale and the only other distros I've found which have this problem are Slax and the 1.0 release of its successor, Porteus, both of which use ISO-8859-1 (latin1) for filenames. |
|
159 | OpenPandora Main OS | Base OS | Bug Report | Medium | System > Run PND Application menu item does nothing | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
With both Hotfix 3 and Hotfix 4 Beta the Run PND Application menu item fails to do anything.
Possibly related problem is that PND files newly copied to SD card are not recognized and entered on desktop as expected.
When you go to Thunar and right click - execute the PND file, nothing happens.
Possible fix by copying the PND to another folder on the SD card with Thunar.
This makes at least two PND files I had work.
Still no response with "Run PND Application" menu, though. |
|
269 | OpenPandora Main OS | Core | Bug Report | Low | Thunar Slow Exit | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Thunar takes a long time going back to minimenu on exit. You don't notice this when in XFCE but then you are always in the GUI not returning to it.
This started in Hotfix 6 Alpha4 I believe |
|
273 | OpenPandora Development OS | Backend / Core | Bug Report | Medium | TI SGX driver package selection | Unconfirmed | |
AllRelease 2 (Yars Revenge) |
Task Description
The last release of TI Graphics SDK Product to support the 1.0.3 SGX core is 4.04.00.03
The overlay needs to peg the package selection to this version. |
|
336 | OpenPandora Main OS | Core | Bug Report | Medium | Touch screen sensitivity too low | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
The touch screen requires to be used with the stylus or another sharp object. Even if I need to click a desktop icon, and could as well use my finger, the touch screen won't react to my finger at all (even if pressed quite hard). |
|
257 | OpenPandora Main OS | Core | Bug Report | Medium | TV Out script breaks XV/SDL Video playback | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
This seems to be the case with Hot-fix 5 and 6 alpha 4.
I've been able to repeat this bug by re-flashing..
On a fresh re-flash.. installed community codec pack.. Videos will play fine on Panplayer, VLC and Gnome-Mplayer with default settings, which I believe is XV or SDL out in the case of VLC.
Run the TV-out script it will cause a blank black screen during playback.. Disabling TV-out, switching modes, rebooting.. battery out, nothing seems to allows it to work with XV/SDL out again.. I know If I switch to X11 it will make it "work" again, but I notice a bit of lag during playback using X11 compared to XV/SDL out. |
|
296 | OpenPandora Development OS | Backend / Core | Bug Report | Low | upowerd fails to open file /proc/timer_stats | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
Hi,
Upowerd spams each 10 seconds with warning "failed to open file '/proc/timer_stats'".
According to https://bugzilla.redhat.com/show_bug.cgi?id=826191 this feature can be activated in kernel. I'm not sure if upowerd can be told not to check this feature, I haven't been able to find an specific option for that so far. Activating this option in kernel, this warning should be eliminated.
It would help give upowerd data it needs, and also it will stop filling up the log, which then I guess interferes with power saving (active file access while writing into log...). |
|
308 | OpenPandora Main OS | Core | Bug Report | Low | Wireless Network being dropped asks for password | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
When a Wireless Network that is dropped because its signal strength isn't that good gets reconnected to, I am being asked to re-input the password for that network. It would be nice if it just used the password I gave to it when it was able to connect without popping up that dialog box. |
|
328 | OpenPandora Main OS | Core | Bug Report | Low | XFCE desktop icons not displayed when logging on too qu... | Requires testing | |
Release 1 (Zaxxon) |
Task Description
It looks like XFCE cannot find the icons for links/launchers on the desktop, when the user logs on too quickly. This happens either when the session chooser at start-up is disabled, or when the session is being chosen quickly after the session chooser is being displayed (e.g. by pressing enter as soon as the chooser window pops up). The icons are probably not generated yet at that time point.
A simple workaround is adding the command "xfdesktop --reload" to autostart. Couls this be included in the next SuperZaxxon release or a hotfix? |
|
326 | OpenPandora Main OS | Core | Bug Report | Low | XFCE menu not expandingl with stylys and scrolling brok... | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
The XFCE menu does not always show submenues like "Emulators" when being clicked on with the stylus. It only works if the click lasts long or after all menues have been clicked at once with a long click.
Also, tipping on a scroll arrof of menues that are higher than the screen causes the click to be registered as a "click and hold". This leads to the menu being scrolled all the way to the end. |
|
185 | OpenPandora Main OS | Core | Bug Report | Low | Xorg driver should not be dependant on user environment | Unconfirmed | |
Release 1 (Zaxxon) |
Task Description
The patch implementing screen blanking uses the /usr/pandora/scripts/op_lid.sh script to control LCD backlit:
http://git.openpandora.org/cgi-bin/gitweb.cgi?p=openembedded.git;a=blob;f=recipes/xorg-driver/xf86-video-omapfb/pandora_backlight_dim.patch;h=4a0b8432d083c6e7297192a2920c7a777ae3d098;hb=16f3fff44323bd6b4349d909667b51a2fef3f278
The same result can be achieved by using the sys interface:
/sys/devices/platform/twl4030-pwm0-bl/backlight/twl4030-pwm0-bl/bl_power
This approach makes driver independent on particular distribution. The proposed patch is attached. |