Notice: Trying to access array offset on value of type bool in /srv/www/vhosts/openpandora.org/domains/bugs.openpandora.org/httpdocs/scripts/details.php on line 649 FS#334 : op_bright_down.sh: error when decreasing brightness

OpenPandora Main OS

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Core
  • Operating System Release 1 (Zaxxon)
  • Severity Low
  • Reported Version SuperZaxxon Final 1.54
Attached to Project: OpenPandora Main OS
Opened by Alec Moskvin - 06.04.2014
Last edited by Grazvydas - 07.04.2014

FS#334 - op_bright_down.sh: error when decreasing brightness

The script does not handle brightness "0".

If you try to decrease brightness if it's already at 0, it produces errors:

~ # /usr/pandora/scripts/op_bright_down.sh /usr/pandora/scripts/op_bright_down.sh: line 18: [: : integer expression expected /usr/pandora/scripts/op_bright_down.sh: line 22: echo: write error: Invalid argument

Not sure how to attach a patch here, but you can get the change with:

git pull git://git.assembla.com/openpandora-oe.git bug-333

I also changed the script to use /bin/sh since it's a valid posix script.

Closed by  Grazvydas
07.04.2014 21:49
Reason for closing:  Fixed
Additional comments about closing:  Looks good, applied.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing