Notice: Trying to access array offset on value of type bool in /srv/www/vhosts/openpandora.org/domains/bugs.openpandora.org/httpdocs/scripts/details.php on line 649 FS#170 : Executable directories broken

OpenPandora Main OS

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Core
  • Operating System Release 1 (Zaxxon)
  • Severity Medium
  • Reported Version SuperZaxxon Beta 4
Attached to Project: OpenPandora Main OS
Opened by Paul Brook - 29.08.2010
Last edited by Michael Mrozek - 08.02.2011

FS#170 - Executable directories broken

Directory type packages fail to run. i.e. dropping a directory containing PXML.xml and a bunch of files onto the SD card rather than a .pnd package. The application is detected and menu entries created correctly, however pnd_run.sh fails to bind mount the directory due to bogus double quoting. Looks like a failed attempt to handle spaces in the path. Patch below removes these incorrect quotes. --- pnd_run.sh +++ pnd_run.sh.old @@ -161,2 +161,2 @@ elif [ $DFS = directory ]; then - mntline="sudo mount --bind -o ro ${PND} " + mntline="sudo mount --bind -o ro \"${PND}\" "
Closed by  Michael Mrozek
08.02.2011 23:48
Reason for closing:  Fixed
Admin
Michael Mrozek commented on 30.08.2010 02:33
What OS version are you using? This should've been fixed since HF4 B1.
Paul Brook commented on 30.08.2010 17:08
I'm currently running HF3. However the current code from git.openpandora.org/pandora-libraries.git still has the same bug.
Paul Brook commented on 30.08.2010 18:12
I can confirm that this bug is still present in HF4 B4. Attached patch makes directories with spaces work correctly. P.S. I just noticed that my original patch was generate backwards. The problem is that when $mntline is expanded, the shell does not perform quote expansion on the result, and a literal quote characters get passed to mount. The fix is to put the device argument in its own variable.
   patch (1.4 KiB)
Paul Brook commented on 30.08.2010 18:43
Bah. Previous patch has a dumb error that broke ISO images. Fixed in this version.
   patch (1.5 KiB)
Admin
Michael Mrozek commented on 27.09.2010 23:12
Fixed in HF5.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing