Notice: Trying to access array offset on value of type bool in /srv/www/vhosts/openpandora.org/domains/bugs.openpandora.org/httpdocs/scripts/details.php on line 649 FS#143 : LED triggers timer and heartbeat cause freezing when used on the PWM driven LEDs

OpenPandora Main OS

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Core
  • Operating System All
  • Severity Low
  • Reported Version SuperZaxxon Beta 4
Attached to Project: OpenPandora Main OS
Opened by Urja Rannikko - 08.07.2010
Last edited by Grazvydas - 22.08.2010

FS#143 - LED triggers timer and heartbeat cause freezing when used on the PWM driven LEDs

Summary is about all i can dug out now. Somehow related to the PWM driving, because SD, bt and wifi leds work with trigger=timer. NOTE: power and charger leds are driven by PWM (just so you all know what I'm talking about). All i wanted to do was to add blinking power led to low power mode and all i get is a frozen pandora :/.
Closed by  Grazvydas
22.08.2010 20:40
Reason for closing:  Fixed
Urja Rannikko commented on 30.07.2010 22:27
I've found a possible cause for this. In short: the PWM led drivers cant be called from interrupt context because they use twl4030_i2c_read/write that uses a mutex (that causes a BUG: scheduling while atomic with my new preemptive kernel). I'm thinking that twl4030_i2c_read/write should be fixed instead of iffy workarounds elsewhere, and I'm going to go googling about this....
Urja Rannikko commented on 31.07.2010 01:41
Okay, here goes a quite clean fix IMHO. It seems that we must allow sleeping when doing I2C stuff, so if called in interrupt/atomic context, the driver will defer the work with schedule_work. EDIT: And now the patch is also attached :P
   0001-Fix-TWL4030-PWM-LED-driv... (3 KiB)
Grazvydas commented on 22.08.2010 20:40
Thanks for the patch. Applied, but changed to always use the workqueue, as I didn't feel confident with your check.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing