Notice: Trying to access array offset on value of type bool in /srv/www/vhosts/openpandora.org/domains/bugs.openpandora.org/httpdocs/scripts/details.php on line 649 FS#125 : wrong error handling in wl1251 platform initilization

OpenPandora Main OS

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category Core
  • Operating System All
  • Severity Low
  • Reported Version SuperZaxxon Beta 4
Attached to Project: OpenPandora Main OS
Opened by Denis - 25.06.2010
Last edited by Grazvydas - 25.06.2010

FS#125 - wrong error handling in wl1251 platform initilization

in http://git.openpandora.org/cgi-bin/gitweb.cgi?p=pandora-kernel.git;a=blob;f=arch/arm/mach-omap2/board-omap3pandora.c;h=c6637426bf3a61f5bd0f85338304d0d8d114f67d;hb=HEAD I see: 555 ret = gpio_request(PANDORA_WIFI_IRQ_GPIO, "wl1251 irq"); 556 if (ret < 0) 557 goto fail_nreset; the goto should go to: fail_irq instead of fail_nreset Denis
Closed by  Grazvydas
25.06.2010 15:41
Reason for closing:  Not a bug
Grazvydas commented on 25.06.2010 15:40
No it should not, if gpio_request fails it means it's not requested and there is no need to free it (in fact that would be wrong and cause warning from gpiolib).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing