- Status Unconfirmed
- Percent Complete
- Task Type Bug Report
- Category Core
- Operating System All
- Severity High
- Reported Version Hotfix 5
FS#229 - Enable wake on alarm interrupts
Found I'd kept some notes about making the Pandora's wake on alarm function work...
drivers/rtc/rtc-twl4030.c
twl4030_rtc_remove (for when the driver is removed) and twl4030_rtc_
shutdown (for when the system is shutdown) functions need to change. Or at least the shut down does.
oh YUK who's been using goto....
changes in drivers/rtc/rtc-twl4030.c
twl4030_rtc_remove
commented out //mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_ALARM_M);
twl4030_rtc_shutdown
replaced
// mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M |
// BIT_RTC_INTERRUPTS_REG_IT_ALARM_M);
with
mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M);
twl4030_rtc_suspend
replaced
// mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M |
// BIT_RTC_INTERRUPTS_REG_IT_ALARM_M);
with
mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M);
twl4030_rtc_init
added (before return!)
twl4030_rtc_alarm_irq_set_state(true);
Should probably check reg 0x2B with mask 0x08 to see if alarm should be left enabled or not ?
but only in twl4030_rtc_shutdown and ?remove? NOT in twl4030_rtc_init
should remove ever happen ???
I'm guessing it's best to not enable the alarm irq's all the time???