- Status Closed
- Percent Complete
- Task Type Bug Report
- Category Core
- Operating System All
- Severity Medium
- Reported Version SuperZaxxon Beta 4
Attached to Project: OpenPandora Main OS
Opened by Urja Rannikko - 27.06.2010
Last edited by Michael Mrozek - 21.07.2010
Opened by Urja Rannikko - 27.06.2010
Last edited by Michael Mrozek - 21.07.2010
FS#131 - bluetooth drivers read timeout too trigger-happy/logic fail?
Shamelessly plugged from the forums, to get proper bug tracking and notifications on this. My post:
@notaz:
+ /* there hould be no rx in progress at this point */
+ if (info->rx_skb != NULL) {
+ dev_err(info->dev, "Receive timed out, %i done, %li left, "
+ "LSR=%02x, IER=%02x\n", info->rx_skb->len + 1,
+ info->rx_count, hci_h4p_inb(info, UART_LSR),
+ hci_h4p_inb(info, UART_IER));
+ info->rx_timed_out = 1;
+ }
Could you share your rationale for that comment in drivers/bluetooth/hci_h4p/core.c? (Oh and there's a typo, too :P )
EDIT: Asking this because commenting that block out changed status of bluetooth (for me) from unusable (can receive ~20-500kB of data before ppp connection halting) to fully working - used to have big problems playing 32kbps AAC stream (max 2 min), now already 4 mins of 96kbps, but i still think we need some receive timeout mechanism, but this one (as it currently stands) doesnt work.
Notaz's reply:
I don't really remember, it was more than 1.5 years ago. That driver is a hack, will need to review it, does it work stable with that code removed?
My reply:
For the non-IRC people:
urjaman on IRC said:
(22:47:45) urjaman: notaz: about stability: i'm on irc atm with that driver, its been playing internet radio for a few hours without problems now, but i don know for sure.
(22:48:00) urjaman: *dont know
(22:50:11) urjaman: my logic: if the serial port _never_ misses a byte it should be ok - IMO scary without some receive timeout, but works for me
Closed by Michael Mrozek
21.07.2010 00:49
Reason for closing: Fixed
Additional comments about closing: Tested and working. Will be included in Hotfix 4.
21.07.2010 00:49
Reason for closing: Fixed
Additional comments about closing: Tested and working. Will be included in Hotfix 4.